Re: [PATCH] Make SVN_STREAM_CHUNK_SIZE internal and tweak it

* Peter N. Lundblad wrote:

> I wanted to put SVN__STREAM_CHUNK_SIZE in svn_private_config.h to avoid
> cluttering a public header with an internal constant, but that didn't
> work in mod_dav_svn, because Apache headers spits out its own autoconf
> generated macros for everyone to just swallow. I've made it internal,
> noted that in the docstring and hidden it from doxygen, so I did what I
> could:-)
>
> Any objections?

If you make it private, please add an accessor function to retrieve the
value. For example, the macro is also often used in bindings applications
as the default stream buffer size (see svn.fs SVN::CORE etc). Third party
apps might use it, too.

nd

-- 
Da fällt mir ein, wieso gibt es eigentlich in Unicode kein
"i" mit einem Herzchen als Tüpfelchen? Das wär sooo süüss!
                                 -- Björn Höhrmann in darw
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org