[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add a keyword+eol translating stream

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-30 01:22:32 CET

Julian Foad wrote:
> Erik Huelsmann wrote:
>
>> I'm hoping for comments.
>
> +1 in principle. I haven't got time to review it this week. I just had
> a quick browse through the diff and made a few comments.

I see you heeded most of my comments before committing r17559; thanks.

>> + /* No reason to choose either source or destination,
>> + other than to exercise all code paths */
>> + if (expand)
>> + src_stream = svn_subst_stream_translated (src_stream,
>> + eol_str, repair,
>> + keywords, expand, pool);
>> + else
>> + dst_stream = svn_subst_stream_translated (dst_stream,
>> + eol_str, repair,
>> + keywords, expand, pool);
>
> It's not this function's job to exercise your new code paths! By all
> means try this as a form of regression test but, for committing to the
> repository, if you can make this function simpler by cutting out the
> "if" and one of the paths, please do, although it seems to me that it
> would be even simpler, and thus better, if you just left it how it was.
> Presumably you will soon add some code that really needs the translated
> stream, and that will exercise it.

What did you think of this? Not much, it appears! (If you've replied, I
haven't received it.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 30 01:23:35 2005

This is an archived mail posted to the Subversion Dev mailing list.