Re: [PATCH] Add a keyword+eol translating stream

Julian Foad wrote:
> Erik Huelsmann wrote:
>
>> I'm hoping for comments.
>
> +1 in principle. I haven't got time to review it this week. I just had
> a quick browse through the diff and made a few comments.

Now you've committed it I noticed another one:

> +struct translation_baton
> {
> + const char *eol_str;
> + svn_boolean_t repair;
> + apr_hash_t *keywords;
> + svn_boolean_t expand;
> + const char *interesting;
> + apr_size_t eol_str_len;
> + char newline_buf[2];
> + apr_size_t newline_off;
> + char keyword_buf[SVN_KEYWORD_MAX_LEN];
> + apr_size_t keyword_off;
> + char src_format[2];
> + apr_size_t src_format_len;
> +} translation_baton;

I think that mention of "translation_baton" at the end declares a variable that
isn't used.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 30 01:18:45 2005