[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disambiguate (de)translation; followup (v3)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-23 01:08:07 CET

Erik Huelsmann wrote:
> On 11/20/05, Julian Foad <julianfoad@btopenworld.com> wrote:
>>
>>After making several comments on these doc strings, below, I wonder if you
>>would like to commit the code changes (except for renumbering the TO/FROM_NF
>>flags, if you agree), and then address the doc strings separately.
>
> Umm, what do you mean by the "except for renumbering the flags"? You
> mean that that's not a code change? or that it *is* a code change?
>
> Well, I'd indeed like to commit the code changes, but am just asking
> if we mean the same (ie that I'll be *including* the flags
> renumbering, because otherwise the assert in svn_wc_translated_file2
> is useless).

By "(except ... if you agree)" I meant "but don't renumber the flags; I hope
you agree with the reason I gave for leaving them as they were".

I think the numbering of the TO/FROM flags should be as before, not changed,
i.e. one of them should be zero, and the "assert" should not be present.

Did you understand my reason: that the two symbolic constants represent the two
states of a single boolean option, and so they shouldn't use two separate bits
in the "flags" field?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 23 01:09:02 2005

This is an archived mail posted to the Subversion Dev mailing list.