[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disambiguate (de)translation; followup (v3)

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-22 23:12:35 CET

On 11/20/05, Julian Foad <julianfoad@btopenworld.com> wrote:
> Erik Huelsmann wrote:
> > Ok, I think I addressed all concerns in the patch below. If we're 99%
> > there, I think I can commit and work from there.
>
> > [[[
> > Followup to r17362.
> >
> > Suggested by: julianfoad
> > malcolm
> >
> > * subversion/include/svn_subst.h:
> > Doc string expansions, including elimination 'detranslate'-like words.
>
> After making several comments on these doc strings, below, I wonder if you
> would like to commit the code changes (except for renumbering the TO/FROM_NF
> flags, if you agree), and then address the doc strings separately.

Umm, what do you mean by the "except for renumbering the flags"? You
mean that that's not a code change? or that it *is* a code change?

Well, I'd indeed like to commit the code changes, but am just asking
if we mean the same (ie that I'll be *including* the flags
renumbering, because otherwise the assert in svn_wc_translated_file2
is useless).

bye,

Erik.
Received on Tue Nov 22 23:20:41 2005

This is an archived mail posted to the Subversion Dev mailing list.