[PATCH] Extra integrity test for svnadmin dump/verify (was Re: svnadmin dump/verify not working as expected?)

On Tuesday 15 November 2005 09:18, kfogel@collab.net wrote:
[snip]
> That sounds sensible to me, if we're going to call this "verification" :-).
> Thanks for digging into the code to figure out what was happening.

I put together a patch that does an extra check to make sure the actual file
length matches the length stored in the repository. It doesn't come without
a consequence though. In this case, it means that if the length of the
svndiff was small for a file, that you can no longer dump that revision in
your repository (it would error out on both svnadmin verify and svnadmin
dump). I'm not sure how I feel about that. One the one hand, you don't
detect the potential corruption until you try to load from the dump. On the
other hand, without this fix, you get a dump file that can be modified and
adjusted to match reality, even though it won't load without modification.

Any opinions? Perhaps I should look at introducing another repos API
specifically for verification?

I've attached the patch and log message for your viewing pleasure. :-)

-John

[[[
Add an extra integrity check to 'svnadmin dump' and 'svnadmin verify' by
ensuring the actual length of a file in the repository matches the expected
length.

* subversion/libsvn_repos/dump.c
  (dump_full_contents): New helper function.

  (dump_node): Use the new dump_full_contents() helper function when we're
  not dumping deltas.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org