[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin dump/verify not working as expected?

From: <kfogel_at_collab.net>
Date: 2005-11-15 15:18:41 CET

John Szakmeister <john@szakmeister.net> writes:
> It appears that it does the checksumming, but it's only checked if you
> get to the end of the file... which makes sense. However, if the
> svndiff that's present doesn't help you to get to that point (i.e.,
> it's shorter than it should be), then the checksum never gets compared
> to the expected checksum.
> I also placed some debugging info into rep_read_contents_close(), and
> it appears that close isn't always called for each rep that has it's
> contents read. I'm not sure if that's a bug or not. It would be nice
> if the routines at least did a check to make sure that if the svndiff
> was used entirely, and we still haven't reached the expanded length,
> then throw an error indicating that the svndiff is incomplete or
> short. Does that sound fair? If so, I can go and write a patch to
> implement this extra checking. I think it would be very helpful for
> those of us fixing peoples' repositories (I've fixed 3 FSFS repos in
> the last couple months.).

That sounds sensible to me, if we're going to call this "verification" :-).
Thanks for digging into the code to figure out what was happening.


www.collab.net  <>  CollabNet  |  Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 15 16:39:21 2005

This is an archived mail posted to the Subversion Dev mailing list.