Re: [PATCH] svn_client_copy/move doc string additions

Philip Martin wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>Does this doc string addition say the right thing?
>
> I think the information is correct, but possibly incomplete.

Thanks. Committed in r17415.

>>+ * Attempt to create any parent directories for @a dst_path that do not exist.
>>+ *
>>+ * If @a dst_path already exists and is a directory, copy the item into that
>>+ * directory, keeping its name (the last component of @a src_path),
>>+ * otherwise copy the item to the new path and name @a dst_path.
>>+ * If @a dst_path already exists and is not a directory, fail.
>
> It covers one particular failure mode, but doesn't explicitly cover
>
> cp src/foo dst/bar
>
> where dst/bar/foo exists.

Likewise the doc string doesn't cover

   cp src/foo dst/bar

where dst/bar exists and is a file (and the behaviour in both cases could
differ depending on whether foo is a file or a directory).

I'm not too sure what it's intended to do and not especially keen on just
poking around in the implementation and documenting what I find there - but I
suppose I should do that. Later.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 17 16:02:33 2005