Re: [PATCH] svn_client_copy/move doc string additions

Julian Foad <julianfoad@btopenworld.com> writes:

> Does this doc string addition say the right thing?

I think the information is correct, but possibly incomplete.

>
> - Julian
> Add important details to doc strings for svn_client_copy/move.
>
> * subversion/include/svn_client.h
> (svn_client_copy): Mention other aspects of its behaviour.
> (svn_client_move): Mention other aspects of its behaviour. Fix typos.
>
> Index: subversion/include/svn_client.h
> ===================================================================
> --- subversion/include/svn_client.h (revision 17263)
> +++ subversion/include/svn_client.h (working copy)
> @@ -1682,6 +1682,13 @@ svn_client_resolved (const char *path,
> * until a commit occurs. This scheduling can be removed with
> * svn_client_revert().
> *
> + * Attempt to create any parent directories for @a dst_path that do not exist.
> + *
> + * If @a dst_path already exists and is a directory, copy the item into that
> + * directory, keeping its name (the last component of @a src_path),
> + * otherwise copy the item to the new path and name @a dst_path.
> + * If @a dst_path already exists and is not a directory, fail.

It covers one particular failure mode, but doesn't explicitly cover

    cp src/foo dst/bar

where dst/bar/foo exists.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org