[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Avoid extra stat calls during report_revisions on some filesystems

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-11-17 06:33:53 CET

Daniel Berlin wrote:
> This patch is an implementation of the idea i posted in the thread
> titled "The cost of svn_io_get_dirents2 and early error messages".
> It uses a function that only gets filenames in the directory, instead of
> extra information that we don't really need, and pushes the error
> handling down into the adm retrieval function.
Not just the error handling, also the stat'ing.

Which, I suspect, will hurt performance on filesystems where you get
stat info for free with the list of file names. That includes all
Windows filesystems.

Wouldn't it be better if svn_io_get_dir_filenames returned the same kind
of hash as svn_io_get_dirents2, but only filled in the other info if
it's available? IIRC APR will tell us which fields in the apr_finfo_t
are valid, and will fill more than just the name, even if that's all you
request. Later on, this information could be used to avoid further stats.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 17 06:34:16 2005

This is an archived mail posted to the Subversion Dev mailing list.