[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]: Avoid extra stat calls during report_revisions on some filesystems

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-16 17:06:47 CET

This patch is an implementation of the idea i posted in the thread
titled "The cost of svn_io_get_dirents2 and early error messages".

It uses a function that only gets filenames in the directory, instead of
extra information that we don't really need, and pushes the error
handling down into the adm retrieval function.

The error handling is also now better, so that we produce actually
useful messages if you do things like remove the .svn directory from a
working copy, etc.

[[[

  Add new function to get filenames in a directory without extra stat
  information, and ues it during revision reporting to avoid extra stat
  calls on some filesystems.

  * subversion/include/svn_io.h
    (svn_io_get_dir_filenames): New function.

  * subversion/libsvn_wc/adm_crawler.c
    (report_revisions): Use svn_io_get_dir_filenames, and don't do
    error checking here.

  * subversion/libsvn_wc/lock.c
    (svn_wc_adm_retrieve): Do better error message reporting here.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Nov 16 17:08:12 2005

This is an archived mail posted to the Subversion Dev mailing list.