Re: svn_io_file_rename preserves *destination* file permission on Windows

On 11/15/05, Ivan Zhakov <chemodax@gmail.com> wrote:
> On 11/15/05, Branko Čibej <brane@xbc.nu> wrote:
> > Erik Huelsmann wrote:
> > > So, I suppose I should be testing trunk on a windows box and see what
> > > happens if I change svn_io_file_rename...
> > >
> > Something bad, I'm pretty sure, or I wouldn't have made the original
> > commit. :)
> I have just removed setting destination read-only after rename and all
> tests passes on Windows (except propt_tests.py 16 which is failling
> before change).

Could you reduce svn_wc__prep_file_for_replacement to 'return
SVN_NO_ERROR;' and see if tests still pass? (Yes, with the changed
svn_io_file_rename please.)

Before deciding to really rip that specific part of the code, it would
be good to find out if any tests were created to test for the
semantics Branko is referring to (not necessarily asking you to do
that though).

bye,

Erik.
Received on Tue Nov 15 12:35:35 2005