[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix verbose list with deleted path over DAV

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-11-11 23:08:43 CET

So issue 2442 is about verbose list not working with peg revisions and
a path that's been deleted in HEAD. It turns out that it only happens
over DAV, and the underlying cause is that we're doing a
svn_ra_get_locks on that path and it errors out. Now svn_ra_get_locks
is supposed to look for the HEAD revision of the repository, since
locks are always on HEAD, that's fine, but I'm not sure it should be
erroring out.

In svn_ra_dav__get_locks, there's a comment that says if the path
doesn't exist in HEAD we should error out, but that's the only place
it's mentioned. The description of the function in svn_ra.h doesn't
mention it, and neither the ra_local or ra_svn versions have the same
comment or the same behavior.

I've got a patch that "corrects" the ra_dav behavior by looking for
the 404 error and simply returning no locks in that case. It seems to
work, but I just wanted to make sure I'm not papering over any
potential problems by catching that error. Anyway, the patch is
attached, and if anyone could give me a "yeah, that seems sane" I'd
appreciate it.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Nov 11 23:09:33 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.