[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The cost of svn_io_get_dirents2 and early error messages

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-11 20:41:41 CET

On Fri, 2005-11-11 at 13:59 -0500, Greg Hudson wrote:
> On Fri, 2005-11-11 at 12:19 -0500, Daniel Berlin wrote:
> > Is it worth the expense of stat'ing every file on every update on some
> > common file systems, just to issue an error message *early* about an
> > incredibly uncommon case that issues an error message anyway?
>
> I agree with you; stat'ing every entry is too much of a cost for this.
>
> On a somewhat orthogonal note, the error mesage "Working copy 'foo' is
> missing or not locked" is, in my view, a bug any time the user sees it.

I agree.
I only know what it was trying to say because i knew what i did :)

> (The kind of "locks" referred to are internal wc locks which only
> concern the user when they have to do "svn cleanup" to *remove* them; it
> is never the user's responsibility to make them happen.) So to the
> extent that we get those messages now or would get them more often
> without the stat calls, we have bugs to fix.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 11 20:45:38 2005

This is an archived mail posted to the Subversion Dev mailing list.