[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn trunk r17244: FAIL (x86_64-unknown-linux-gnu static ra_svn fsfs)

From: David James <james82_at_gmail.com>
Date: 2005-11-09 18:17:23 CET

On 11/9/05, Madan U Sreenivasan <madan@collab.net> wrote:
> On Wed, 2005-11-09 at 09:42, kfogel@collab.net wrote:
> > Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > > On 08 Nov 2005 21:43:39 -0600, kfogel@collab.net <kfogel@collab.net> wrote:
> > >
> > > > Do you see now the beauty that lies within us all?
> > >
> > > Oh, I'm perfectly willing to admit that it would be cool to have such
> > > a thing, but I think it's overkill considering that our current need
> > > is simply a hook script that writes a string to stderr ;-)
> >
> > "Premature cliché is the root of all evil."
> Thanks for all your comments. I did start off with the simple echo, but
> found that implementing this function that could create a python based
> script portable on windows and unix was as simple as indenting my
> existing code and moving it to svntest.
>
> So, here it comes, the test itself is simpler, which uses the new
> function added to svntest.main.
>
> I have not tested this on windows. Could someone do it for me? thanks.
> In case ppl are busy and cant test the script on windows, I'd suggest
> committing the code and wait for the breakage report, because there's no
> extra complexity in the windows code, only that the conditional has not
> been run.
>
> Regards,
> Madan.

Nice work, Madan! I noticed one small problem:

> + file_append (hook,
> + "@echo off\n",
> + hook_py)
On Windows, we need to call Python scripts using the full path to the
Python interpreter. Here is an example:
   file_append(hook, "@%s %s" % (sys.executable, hook.py))

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
Received on Wed Nov 9 18:18:16 2005

This is an archived mail posted to the Subversion Dev mailing list.