[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove unnecessary props read in svn_wc_get_prop_diffs()

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-11-03 21:41:12 CET

On Thu, Nov 03, 2005 at 05:13:41PM +0000, Julian Foad wrote:
> >Just a note that unless I get a comment to the contrary within the
> >next hour or so, I plan to check this patch in as-is, making use of my
> >new-found (and unexpected!) commit access.
> It looks fine to me. If you could put a one-sentence summary at the top of
> your log message, that would be appreciated. (The subject line of this
> thread would do nicely.)

Sure. (That wasn't something I'd realised was part of the log message
style until just recently.)

> Excellent. I'm pleased to note that your patches have been close to
> flawless but I will point out that, in general, writers tend to consider
> their patches to be self-evidently correct more often than readers of them
> do :-)

Heh. Good point!


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 21:42:29 2005

This is an archived mail posted to the Subversion Dev mailing list.