[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove unnecessary props read in svn_wc_get_prop_diffs()

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-03 18:13:41 CET

Malcolm Rowe wrote:
> On Wed, Nov 02, 2005 at 10:46:07PM +0000, Malcolm Rowe wrote:
>
>>Updated patch attached.
>
> Just a note that unless I get a comment to the contrary within the
> next hour or so, I plan to check this patch in as-is, making use of my
> new-found (and unexpected!) commit access.

It looks fine to me. If you could put a one-sentence summary at the top of
your log message, that would be appreciated. (The subject line of this thread
would do nicely.)

> (Or, in other words: I consider the patch to be self-evidently correct,
> and not something that would normally require a review. But since I
> already posted it here, I don't want to just commit it without giving
> anyone who was planning to comment a chance to do so).

Excellent. I'm pleased to note that your patches have been close to flawless
but I will point out that, in general, writers tend to consider their patches
to be self-evidently correct more often than readers of them do :-)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 18:16:06 2005

This is an archived mail posted to the Subversion Dev mailing list.