[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17171 - trunk/subversion/libsvn_wc

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-11-03 18:33:48 CET

On Thu, Nov 03, 2005 at 09:45:09AM -0600, kfogel@collab.net wrote:
> This function, load_base_props(), returns 'void', but you use the
> SVN_ERR() macro in it. This may not have the result you wanted :-).
>

Drat! How did I miss that? (it even generates a warning!)

I'll change load_base_props() to return svn_error_t* and adjust both
callers (shortly). Part of the problem that r17171 is trying to fix
is that we ignored legitimate errors (corrupt files, for example) when
loading the properties, so propagating the error to the callers is
correct.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 18:35:14 2005

This is an archived mail posted to the Subversion Dev mailing list.