[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17171 - trunk/subversion/libsvn_wc

From: <kfogel_at_collab.net>
Date: 2005-11-03 16:45:09 CET

malcolm@tigris.org writes:
> --- trunk/subversion/libsvn_wc/diff.c (original)
> +++ trunk/subversion/libsvn_wc/diff.c Thu Nov 3 09:40:10 2005
> @@ -348,13 +348,10 @@
> actually the working props. that's what we do with texts,
> anyway, in the 'svn diff -rN foo' case. */
>
> - /* also notice we're ignoring error here; there's a chance that
> - this path might not exist in the working copy, in which case
> + /* This path might not exist in the working copy, in which case
> the baseprops remains an empty hash. */
> - svn_error_t *err = svn_wc_prop_list (&(b->baseprops), b->path,
> - b->edit_baton->anchor, b->pool);
> - if (err)
> - svn_error_clear (err);
> + SVN_ERR (svn_wc_prop_list (&(b->baseprops), b->path,
> + b->edit_baton->anchor, b->pool));
> b->fetched_baseprops = TRUE;
> }

This function, load_base_props(), returns 'void', but you use the
SVN_ERR() macro in it. This may not have the result you wanted :-).

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 18:04:29 2005

This is an archived mail posted to the Subversion Dev mailing list.