Re: [PATCH] mailer.py: truncate_diff_lines feature

On Thu, 03 Nov 2005, Branko ?ibej wrote:
> In that case, I suggest defining some maximum diff size, and if the
> diff exceeds that size to not in include it in the mail at all. Just
> add a note, e.g. "Diff ommitted, because it's longer than N lines.

I can add that as another feature, if there is demand for it. The
behaviour that I have already implemented is the one that's more useful
to me. Two other people have said that this behaviour is useful to them
too.

How about something like this (also changing the variable name, because
it would no longer be just for truncation):

   max_diff_lines = 0 # no limit (default)
   max_diff_lines = 100 # diffs longer than 100 lines are omitted
   max_diff_lines = -100 # diffs longer than 100 lines are truncated

--apb (Alan Barrett)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 08:59:19 2005