[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow anonymous ra_svn write access

From: Paul Burba <paulb_at_softlanding.com>
Date: 2005-11-02 15:34:22 CET

Philip Martin <philip@codematters.co.uk> wrote on 11/01/2005 04:04:15 PM:

> Philip Martin <philip@codematters.co.uk> writes:
>
> > It looks like it's a result of the way the authz stuff handles lock
> > tokens. I'm don't know much about this bit of code, does the
> > following look sensible?
> >
> > Fix a bug that caused anonymous write access over ra_svn to fail
> > with "Authorization failed" errors.
> >
> > * subversion/svnserve/serve.c
> > (commit): Don't require a username if there are no lock tokens.
>
> The patch Paul Burba just posted in a separate thread also does the
> trick; I suspect his approach might be better, but I don't really know
> the code well enough to say.

Hi Philip,

Both of our patches solve the original problem, but like you, I'm not
entirely sure which is better and judging if there are no unintended
side-effects from either...well that's another question entirely.

For now I'm going to continue testing my 1.3 ebcdic port (which is how I
originally came across the same problem you did) with my patch in place
and see if anything else falls out. In the meantime, if someone out there
knows this section of code and can spare some time to take a look at
either patch, please do.

Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 2 15:36:04 2005

This is an archived mail posted to the Subversion Dev mailing list.