Re: [PATCH] mailer.py: truncate_diff_lines feature

Alan Barrett <apb@cequrux.com> writes:

> [[[
> Add truncate_diff_lines feature to mailer.py hook script. If this
> is set to a non-zero value, then diffs longer than the specified
> number of lines will be truncated in email messages.

"truncate_diff_lines" sounds like you're chopping characters off the
ends of long lines, not chopping lines off the end of a long diff.
Suggest "truncate_diff".

I'm somewhat ambivalent about this feature addition, but do have one
concern: I'd prefer it if the act of truncating a diff would cause an
application of that diff data as a patch to fail in some noticable
way. In a sea of 100 diffs in a single email, it'd be really easy to
miss a single instance of a truncated one -- what happens to the poor
guy that tries to apply that email as a patch and succeeds because the
truncation happened to line up with a hunk boundary?

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org