[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix issue #2353 (commit switched error "missing or not locked")

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-10-29 00:56:48 CEST

On 10/20/05, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> So I looked into issue 2353, which is a problem committing files under
> switched directories, and came up with a patch that fixes the problem,
> but I'm not sure it's correct. According to cmpilato's comments in
> the issue, the problem is that svn_wc_get_actual_target isn't doing
> the right thing for commits, and fixing the underlying code isn't
> trivial. I took a different approach, and just removed the call to
> svn_wc_get_actual_target entirely.
> My new version of svn_client_commit3 simply checks if the target path
> is a directory, does the locking we would have done with the return
> value from svn_wc_get_actual_target, and then splits off the dirname
> so we can use it later. This seems to work (all tests pass, the XFail
> test for this issue passes, etc), but I get the feeling that it's too
> easy, I must be missing something fundamental about why we were using
> svn_wc_get_actual_target in the first place.
> Comments?

Ping? Anyone feel like taking a look at this patch? As far as I can
tell it fixes the problem and it doesn't cause any test breakage, so
unless someone points out some glaring issue with it I'm leaning
towards checking it in...


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 29 00:57:42 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.