[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17077 - in trunk/subversion: libsvn_subr mod_authz_svn

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-10-28 19:21:54 CEST

On 10/28/05, kfogel@tigris.org <kfogel@tigris.org> wrote:

> void
> svn_handle_warning2 (FILE *stream, svn_error_t *err, const char *prefix)
> {
> + char buf[256];
> +
> svn_error_clear (svn_cmdline_fprintf
> (stream, err->pool,
> _("%swarning: %s\n"),
> - prefix, (err->message ? err->message :
> - "[no further information available]")));
> + prefix, svn_err_best_message (err, buf, 256)));

s/254/sizeof (buf)/

> + char errbuf[256];
>
> switch (r->method_number) {
> /* All methods requiring read access to all subtrees of r->uri */
> @@ -239,9 +240,7 @@
> svn_err->apr_err < APR_OS_START_CANONERR) ?
> 0 : svn_err->apr_err),
> r, "Failed to load the AuthzSVNAccessFile: %s",
> - (svn_err->message ?
> - svn_err->message :
> - "[no further information available]"));
> + svn_err_best_message(svn_err, errbuf, 256));

ditto.

> svn_error_clear(svn_err);
>
> return DECLINED;
> @@ -291,9 +290,7 @@
> svn_err->apr_err < APR_OS_START_CANONERR) ?
> 0 : svn_err->apr_err),
> r, "Failed to perform access control: %s",
> - (svn_err->message ?
> - svn_err->message :
> - "[no further information available]"));
> + svn_err_best_message(svn_err, errbuf, 256));

ditto.

> svn_error_clear(svn_err);
>
> return DECLINED;
> @@ -339,9 +336,7 @@
> svn_err->apr_err < APR_OS_START_CANONERR) ?
> 0 : svn_err->apr_err),
> r, "Failed to perform access control: %s",
> - (svn_err->message ?
> - svn_err->message :
> - "[no further information available]"));
> + svn_err_best_message(svn_err, errbuf, 256));

ditto.

Other than that looks good to me.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 28 19:28:25 2005

This is an archived mail posted to the Subversion Dev mailing list.