Re: ViewCVS broken for r17006

On Fri, Oct 28, 2005 at 09:25:57AM -0400, C. Michael Pilato wrote:
> > The '--strict' option just prevents the terminating newline from being
> > output by the client, nothing else.
>
> It better do more than that, because I added it (in r5424) to support
> byte-for-byte output of binary property values. It was touched up
> later (r14505) to not print a trailing newline when used on revprops.
>

No, actually, that _is_ all it does. The binary property stuff you added
in r5424 is done unconditionally. Oh, all right: it also suppresses
filenames in multi-target propgets.

> But yeah, as you noted, our svn: props get munged and translated and
> stuff, so the --strict output isn't so strict after all for those
> properties.
>

Sure. And so as a result, we can't be sure we've got the original property
value. Would it maybe make sense to disable the translation completely
when --strict is used?

> > Because _that_ revision was committed by the EBCDIC guys, and I'm
> > immediately suspicious of anything their weird non-ASCII clients might be
> > doing?
>
> Ah, I didn't make that connection. Interesting...
>

Unfortunately, I don't think it bears up (and I _was_ kidding; hope
I made that clear) - there are a number of other commits from those
clients that don't have this problem.

No, I think this is going to actually require someone to look at what
the Python binding are returning on the server.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 28 16:20:11 2005