[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Modify JavaHL test suite to use SVNClientSynchronized class

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-10-27 20:03:12 CEST

It seems like the JavaHL test suite would be better served by constructing
an SVNClientSynchronized instead of an SVNClient. The former just wraps
Java thread synchrnonization around the latter and by using it, you
essentially are testing both classes.

This would have caught the problem for the other patch I just sent.

Thanks

Mark

Index: src/org/tigris/subversion/javahl/tests/SVNTests.java
===================================================================
--- src/org/tigris/subversion/javahl/tests/SVNTests.java (revision
17058)
+++ src/org/tigris/subversion/javahl/tests/SVNTests.java (working
copy)
@@ -211,7 +211,7 @@
 
         // create and configure the needed subversion objects
         admin = new SVNAdmin();
- client = new SVNClient();
+ client = new SVNClientSynchronized();
         client.notification2(new MyNotifier());
         client.commitMessageHandler(new MyCommitMessage());
         client.username("jrandom");

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 27 20:24:32 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.