Re: [PATCH] improve speed of non-verbose svn list, take 2

On 10/27/05, Peter N. Lundblad <peter@famlundblad.se> wrote:

> > get-dir
> > - params: ( path:string [ rev:number ] want-props:bool want-contents:bool )
> > + params: ( path:string [ rev:number ] want-props:bool want-contents:bool
> > + [ dirent-field:string ... ] )
>
> The last part should read "? ( dirent-field:word ...)".

Ahh, ok, my mistake.

> Even better would be to define:
> dirent-field: size | has-props | WHATEVER | word
> and use that. ("word" would allow for future extensibility.)

Yes, I agree, that does make more sense. My current version looks like this:

  get-dir
    params: ( path:string [ rev:number ] want-props:bool want-contents:bool
                ? ( field:dirent-field ... ) )
    response: ( rev:number props:proplist ( entry:dirent ... ) )]
    dirent: ( name:string kind:node-kind size:number has-props:bool
                created-rev:number [ created-date:string ]
                [ last-author:string ] )
    dirent-field: kind | size | has-props | created-rev | time | last-author
                  | word

Does that seem reasonable?

> > - entry->has_props = (apr_hash_count(file_props) > 0) ? TRUE : FALSE;
> > + if (dirent_fields & SVN_DIRENT_SIZE)
>
> ^ should be HAS_PROPS

Oops. Good catch.

> Else, it looks good to me.

Great, thanks for the review!

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 27 20:22:28 2005