[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 2419] New - 'svn rm' of schedule add leaves working props file

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-10-26 14:36:45 CEST

> ------- Additional comments from philip@tigris.org Mon Oct 17 17:00:23 -0700 2005 -------
> Deleting a schedule add item should remove all properties for that item, but it
> doesn't:
> svnadmin create repo
> svn co file://`pwd`/repo wc
> touch wc/foo
> svn add wc/foo
> svn ps xx xx wc/foo
> svn rm --force wc/foo
> touch wc/foo
> svn add wc/foo
> svn pl -v wc/foo
> The proplist shows that the xx property has survived the rm. If I use revert
> instead of rm the property does get deleted.
> rm and revert on a schedule add file should be similar, the only difference
> being that rm deletes the working file while revert leaves it unversioned, yet
> the implementations are totally different: rm uses log files while revert
> modifes the working copy directly. Does anyone know how these things are
> supposed to work?

Yes, I do.

The effects should be equal and both svn_wc_delete2 and svn_wc_revert2
should be using logs. Actually, more generally: every working copy
action which modifies more than 1 state in an operation
(svn_wc_delete2 and _revert2 both change working copy files, props
files and entries, which add up to a minimum of 3 changes) should use
log files to do the work.

The conclusion should be we need another issue to record the fact that
svn_wc_delete2() isn't loggy.

Does this answer your question, or did you mean to ask a different one?


Received on Wed Oct 26 14:38:46 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.