Re: [PATCH] Move unused parameter warning suppression into a macro

> I'm still thinking about whether we can do better than putting the definition
> in svn_types.h. We really should try hard to avoid using that file as a
> dumping ground. I'm thinking svn_private_config.h would be better, since this

+1

> is an implementation detail that users of our libraries don't need to know
> about, and since the appropriate definition might depend on the compilation
> environment. For example, some compilers might complain more about "(void)x"
> being a statement with no effect than they do about unused parameters.

Which may mean that at some time we need to implement configure magic
to check for it... (which means it'll be in svn_private_config.h by
then)

bye,

Erik.
Received on Wed Oct 26 13:21:32 2005