Re: [PATCH] Move unused parameter warning suppression into a macro

Julian Foad wrote:
> Jonathan Gilbert wrote:
>
>>
>> Move unused parameter warning suppression into a macro instead of
>> directly
>> using "(void)p;" or "p=p;" in otherwise semantically-oriented source
>> code.
>
>
> Are you planning to follow up with a patch that inserts this macro into
> the dozens (from memory) of other places where we intentionally ignore a
> parameter, so as to make the whole build "clean"? If so, +1; if not, I
> don't think there is any point in having this and we should just delete
> those three instances of ad-hoc warning-suppression that you found.

I believe that this is a good patch. Yes, it will be nice to fix all
of the warnings, but even if it does not do so in one patch does not
mean that it is a bad idea or a step in the wrong direction.

(Personally, my own code always must compile clean - no warnings - before
I release - so any steps to that condition are good, IMHO)

PS - if someone were to get all warnings out in a single patch, would that
be something to look at? I assume we are mainly worried about GCC. The
HPUX C/C++ compiler is the best warning generating compiler that I have
ever run into but I currently do not have access to such a machine.

-- 
Michael Sinz                     Technology and Engineering Director/Consultant
"Starting Startups"                                mailto:michael.sinz@sinz.org
My place on the web                            http://www.sinz.org/Michael.Sinz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org