[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Move unused parameter warning suppression into a macro

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-10-25 12:01:03 CEST

Jonathan Gilbert wrote:
> Move unused parameter warning suppression into a macro instead of directly
> using "(void)p;" or "p=p;" in otherwise semantically-oriented source code.

Are you planning to follow up with a patch that inserts this macro into the
dozens (from memory) of other places where we intentionally ignore a parameter,
so as to make the whole build "clean"? If so, +1; if not, I don't think there
is any point in having this and we should just delete those three instances of
ad-hoc warning-suppression that you found.

- Julian

> +#define SVN_UNUSED_PARAMETER(x) ((void)x)
> Index: subversion/libsvn_wc/adm_files.c
> Index: subversion/libsvn_subr/config.c

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 25 12:02:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.