Re: svn commit: r16853 - trunk/subversion/libsvn_wc

On 10/20/05, Daniel Rall <dlr@finemaltcoding.com> wrote:
> On Thu, 20 Oct 2005, Ivan Zhakov wrote:
>
> > On 10/20/05, Daniel Rall <dlr@finemaltcoding.com> wrote:
> > > On Thu, 20 Oct 2005, zhakov@tigris.org wrote:
> ...
> > > > --- trunk/subversion/libsvn_wc/props.c (original)
> > > > +++ trunk/subversion/libsvn_wc/props.c Thu Oct 20 10:34:03 2005
> > > > @@ -208,6 +208,44 @@
> > > >
> > > > /*** Misc ***/
> > > >
> > > > +/* Opens reject temporary file for FULL_PATH. */
> > > > +static svn_error_t *
> > > > +open_reject_tmp_file (apr_file_t **fp, const char **reject_tmp_path,
> > > > + const char *full_path,
> > > > + svn_wc_adm_access_t *adm_access,
> > > > + svn_boolean_t is_dir, apr_pool_t *pool)
> > > > +{
> > > > + const char *tmppath, *tmpname;
> > >
> > > There is a parameter named "reject_tmp_path" to this function, yet neither
> > > of the local variables defined above uses that same -- slightly more
> > > comprehensible -- naming convention which uses the underscore to emphasize
> > > word boundries (e.g. "tmp_path"). Both style came from pre-refactoring, but
> > > it would be nice if the refactoring made them consistent.
> >
> > To be clear: do you propose simply rename tmppath and tmpname
> > variables to tmp_path and tmp_name and nothing more? I don't take
> > myslef rename it on refactoring, because I am nott familiar with
> > subversion naming conventions in edge cases.
>
> Yeah, that's what I am suggesting.
>
Fixed this and indentation in r16890. Thank you for review.

--
Ivan Zhakov