[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16852 - trunk/subversion/libsvn_ra_dav

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-10-21 08:07:47 CEST

On Thu, 20 Oct 2005, C. Michael Pilato wrote:

> lundblad@tigris.org writes:
>
> [...]
>
> > * subversion/libsvn_ra_dav/fetch.c
> > (report_baton_t): Add pool and in_resource members, change
> > current_wcprop_path to a stringbuf.
> > (svn_ra_dav__get_locations): Use caller-provided pool for temporary stuff.
> > (start_element): Use rb->pool instead of the session pool.
> > When allocating file pools, don't use the session pool, but instead
> > the parent directory pool.
> > Set rb->in_resource to true when setting rb->current_wcprop_path
> > (there is no NULL value any longer).
>
> Just a nit -- this is why I highly endorse indentation in log

Se the propedit for how I "fixed" this:-)

> messages. "(there is no NULL ..." looks like a symbol name. I
> prefer:
>
> * subversion/libsvn_ra_dav/fetch.c
> (report_baton_t): Add pool and in_resource members, change
> current_wcprop_path to a stringbuf.
> (svn_ra_dav__get_locations): Use caller-provided pool for temporary stuff.
> (start_element): Use rb->pool instead of the session pool.
> When allocating file pools, don't use the session pool, but instead
> the parent directory pool.
> Set rb->in_resource to true when setting rb->current_wcprop_path
> (there is no NULL value any longer).
>
Yes, I agree. Let's see if I switch my style:-) It is a balance between
how much time you spend on log message formatting and the chance of
misunderstandings.

> Nice work, Peter. At super-quick glance, the change looks good.
>
>
thanks for having a look and being my spell checker:-(

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 21 08:11:46 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.