[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Seeking JavaHL developers for RC

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-20 22:31:19 CEST

On Thu, 20 Oct 2005, Mark Phippard wrote:
> Does this new method take a path, like "C:\Dev\Project\.svn" or just a
> name like ".svn"?
I had the same question myself while implementing this, and modified the
svn_wc_is_adm_dir() doc string accordingly:

--- svn_wc.h (revision 16862)
+++ svn_wc.h (revision 16863)
@@ -339,7 +339,8 @@
  * Return @c TRUE if @a name is the name of the WC administrative
- * directory. Use @a pool for any temporary allocations.
+ * directory. Use @a pool for any temporary allocations. Only works
+ * with base directory names, not paths or URIs.
  * For compatibility, the default name (.svn) will always be treated
  * as an admin dir name, even if the working copy is actually using an

> In the cases we need this information in Subclipse, I think the other
> method will be more desirable.

I assume you mean that the ability to digest a full path would be more
desirable? (This was my thinking as well.) As the JavaHL binding I
added simply wraps svn_wc_is_adm_dir(), a change to that library would
do the trick here, and sounds like a generally more comfortable API.
Maybe something like...?:

--- adm_files.c (revision 16865)
+++ adm_files.c (working copy)
@@ -57,7 +57,7 @@
 svn_wc_is_adm_dir (const char *name, apr_pool_t *pool)
- (void)pool; /* Silence compiler warnings about unused parameter. */
+ name = svn_path_basename (name, pool);
   return (0 == strcmp (name, adm_dir_name)
           || 0 == strcmp (name, default_adm_dir_name));

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 22:30:36 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.