[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Seeking JavaHL developers for RC

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-20 20:41:26 CEST

On Thu, 20 Oct 2005, Branko Čibej wrote:
> Daniel Rall wrote:
> >On Wed, 19 Oct 2005, Marc Sherman wrote:
> >>Subclipse does a bunch of things with the admin dirs, such as hiding
> >>them from display in the project browsers and not indexing code in the
> >>textbase dirs within them. It currently does this with a hardcoded
> >>constant string defined as ".svn", which I had to hack to "_svn" in a
> >>local build similar to the change in the svn C code. I'd assumed that
> >>Subclipse would want to call the subversion APIs to replace comparisons
> >>with the constant, but if Mark's happy replicating the logic of those
> >>APIs in Subclipse code instead, using the env var directly, then I guess
> >>it's not needed.
> >
> >So exposing svn_wc_get_adm_dir() would be sufficient?
> No, it wouldn't be sufficient. You nead at least svn_wc_is_adm_dir,
> which is more relevant for hiding stuff.

Brane, you suggest this because svn_wc_is_adm_dir() checks not only the
current admin dir, but also the default. I agree; can someone else put
together a patch along the lines of r16854?

svn_wc_is_adm_dir (const char *name, apr_pool_t *pool)
  (void)pool; /* Silence compiler warnings about unused parameter. */
  return (0 == strcmp (name, adm_dir_name)
          || 0 == strcmp (name, default_adm_dir_name));

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 20:40:45 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.