On 10/20/05, Mark Phippard <markp@softlanding.com> wrote:
> OK, I ws able to test trunk on Windows with the SVN_ASP_DOT_NET_HACK
> variable set and not set. Both worked, but only after I made some fixes
> to some hard-coded assumptions in the JavaHL test suite. Patch attached.
>
> I have commit access so I can commit it if I get approval. The patch uses
> the same environment variable checking we are using in Subclipse. Then
> all hard-coded use of ".svn" is replaced by call to a static method
> SVN_DIRNAME() that sets the value based on the environment variable and
> OS.
This seems fine in concept, although exposing the underlying
svn_wc_get_adm_dir function would be better, so we don't need to have
the logic in two places. One thing I did notice about the patch was
that it seems to use a mixture of tabs and spaces. The existing
javahl code appears to use all spaces, so that should be fixed before
committing.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 18:47:56 2005