[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Seeking JavaHL developers for RC

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-20 18:47:49 CEST

On Thu, 20 Oct 2005, Mark Phippard wrote:
...
> OK, I ws able to test trunk on Windows with the SVN_ASP_DOT_NET_HACK
> variable set and not set. Both worked, but only after I made some fixes
> to some hard-coded assumptions in the JavaHL test suite. Patch attached.
 
Thanks for testing it out, Mark!

> I have commit access so I can commit it if I get approval. The patch uses
> the same environment variable checking we are using in Subclipse. Then
> all hard-coded use of ".svn" is replaced by call to a static method
> SVN_DIRNAME() that sets the value based on the environment variable and
> OS.

Though it was the JUnit tests which you modified (which themselves have no JNI
dependency), it still seems like it might be much cleaner to rely on the
return value of svn_wc_get_adm_dir(). What do you think?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 18:46:54 2005

This is an archived mail posted to the Subversion Dev mailing list.