Re: [PATCH] Issue 443 : post-commit hook (error) output lost: Step 6

> > - const char *log_msg, *date, *author;
> > + const char *log_msg = NULL,
> > + *date = NULL,
> > + *author = NULL,
> > + *post_commit_err = NULL;
> >
> > Any reason these are now being initialized to NULL?
>
> Good practice, is it not?

If something depends on them being initialized to NULL, then by all
means they should be initialized, but if we're going to initialize
them to some value later (as this code does, by passing them to a
function that fills them in), then leaving out the explicit setting to
NULL gives the compiler a chance to warn in cases where they will be
used without being initialized. The explicit NULL keeps the compiler
from being able to do that.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 01:39:01 2005