Re: Crash in python bindings on windows (in apache)

At 10:16 PM 19/10/2005 +0200, Brane wrote:
[snip]
>>Supposing "(void)pool" really was the source of the problem in Windows (I
>>don't see how it could be, but...), perhaps something like this would make
>>sense somewhere in a core header:
>>
>>#if NEED_TO_SUPPRESS_UNUSED_PARAMETER_WARNING
>># if defined(WIN32) || defined(WIN64)
>
>Note that this had nothing to do with the platform (e.g., windows in
>this case), but the compiler that's being used ...

True :-)

>># define UNUSED_PARAMETER(x) ((x) = (x))
>
>... and MSVC does the right thing with (void)foo;

Right. I'll use a simpler definition, simply using the (void) hack.

[snip]
>>#endif /* NEED_TO_SUPPRESS_UNUSED_PARAMETER_WARNING */

Should I make it toggle-able like this? I don't know a lot about how
./configure and all that work, so I don't know how to make it an option
like --enable-suppress-unused-parameter-warning or what have you. I'm not
even certain it should be that kind of option. Any advice here? :-)

>+1. Please post a real patch, I'd like to see this in the code, too.
>Of course, the name of the macro has to be namespace protected.

Right.

One patch coming right up :-)

Jonathan Gilbert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 19 22:35:44 2005