On 10/19/05, Branko Čibej <brane@xbc.nu> wrote:
> David James wrote:
>
> >On 10/19/05, Marc Haesen <Marc.Haesen@telindus.be> wrote:
> >
> >
> >>I have just updated my working copy to revision 16815 and after applying
> >>the attached patch (to solve a compilation problem in windows), it seems
> >>not to crash anymore in apache with mod_python.
> >>
> >>In the patch.txt I have just removed the line (void) pool;
> >>It can also replaced by pool=pool; to avoid a warning.
> >>
> >>
> >This is fantastic news, Marc. I have followed your suggested approach,
> >using pool = pool, to avoid a warning in r16817. Thanks so much for
> >your help and your patience!
> >
> >
> I'd really like to know what sort of Windows compile problem the "(void)
> pool" thing caused. This is an idiom we've been using throughout the
> code to silence warnings about unused variables. Changing this single
> isntance is nonsense, especially since the "compile problem" report
> wasn't exactly enlightening.
It does seem strange that "(void) pool;" would not work on Windows,
especially considering how often we use the same idiom elsewhere in
the code:
subversion/libsvn_subr/config.c: (void)(baton); /*
Unused parameter. */
subversion/libsvn_subr/config.c: (void)(section); /*
Unused parameter. */
subversion/libsvn_wc/adm_files.c: (void)pool; /* Silence compiler
warnings about unused parameter. */
subversion/libsvn_wc/adm_files.c: (void)pool; /* Silence compiler
warnings about unused parameter. */
Marc, can you take a look at this?
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Received on Wed Oct 19 21:26:48 2005