[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] psvn: Fix bogus comparisons of buffers to strings.

From: Kalle Olavi Niemitalo <kon_at_iki.fi>
Date: 2005-10-15 02:05:46 CEST

Stefan Reichör <stefan@xsteve.at> writes:

> I have applied that patch now.

While merging psvn.el changes from trunk to a local branch,
I noticed that you didn't apply all of the patch I posted.
I had posted this change:

>> (defun svn-status-show-process-buffer-internal (&optional scroll-to-top)
>> - (when (eq (current-buffer) "`svn-status-buffer-name'")
>> + (when (string= (buffer-name) svn-status-buffer-name)
>> (delete-other-windows))

You applied this in r15969:

 (defun svn-status-show-process-buffer-internal (&optional scroll-to-top)
- (when (eq (current-buffer) "`svn-status-buffer-name'")
+ (when (eq (current-buffer) svn-status-buffer-name)
     (delete-other-windows))

This comparison will always return false.
I'm assuming that was inadvertent, so I'll change it soon.

  • application/pgp-signature attachment: stored
Received on Sat Oct 15 02:00:24 2005

This is an archived mail posted to the Subversion Dev mailing list.