[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2287 - Make svn_client_log() take a peg revision

From: S.Ramaswamy <srsy70_at_gmail.com>
Date: 2005-10-12 22:15:52 CEST

>
> Ah, a red herring it may be, but that's the part I meant I "couldn't
> understand". That's where I got hung up on trying to review the patch. In my
> previous email or two in the thread I queried this, trying to discover why this
> particular part of the patch does what it does, and I couldn't understand
> Ramaswamy's answers.
>

In the mail that I sent with v3 of the patch, I was trying to explain
that (a)It doesn't matter whether you pass the start or the end
revision to svn_client__ra_session_from_path() (b)But there is a case
where it does seem to matter - When the revision range specified
includes a revision in which the file was renamed; Passing the lesser
revision and getting a ra_session from svn_ra_session_from_path()
makes svn_ra_get_log() fail(with that ra_session).
And the example that I gave in that mail was:

For example, if trunk/folder existed between r4 and r6 and was renamed
to trunk/folder1 in r7, then, trying to get the log with 'svn log
-r4:7 trunk/folder1' doesn't work if you are passing the start
revision(4) to svn_client__ra_session_from_path(). But passing the end
revision (7) to svn_client__ra_session_from_path() works. Here's the
result with the actual revision # of the object(rev) and the final
resulting url(url_p) from svn_client__ra_session_from_path() printed
out - In this case the revision was set to start.
-------------------------
svn log -r4:7 trunk/folder1
url_p:file:///home/ramaswamy/issues/2287/repos/trunk/folder
rev:4
subversion/libsvn_fs_fs/tree.c:315
<file:///home/ramaswamy/issues/2287/repos/trunk/folderrev:4subversion/libsvn_fs_fs/tree.c:315>:
(apr_err=160013)
svn: File not found: revision 7, path '/trunk/folder'
-------------------------

Thanks
Ramaswamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 12 22:16:49 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.