[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2287 - Make svn_client_log() take a peg revision

From: S.Ramaswamy <srsy70_at_gmail.com>
Date: 2005-10-12 15:53:40 CEST

> Ramaswamy, I haven't had time to review your patch in detail (sorry!
> just have to give priority to 1.3.x review and voting right now), but
> I did notice one thing. You make the straightforward change of adding
> a 'peg_revision' parameter, thus creating svn_client_log3(), which
> is great. But the new doc string material says:
> + * given log message more than once). @a peg_revision indicates in which
> + * revision @a path_or_url is valid. If @a peg_revision is @c
> + * svn_opt_revision_unspecified, then it defaults to \
> @c svn_opt_revision_head
> + * for URLs or @c svn_opt_revision_working for WC targets.
> I think you must have cut-and-pasted from svn_client_blame2(),
> perhaps? There is no path_or_url parameter in svn_client_log3(). It
> takes a targets array instead, which means that the behavior of the
> peg revision needs w.r.t. multiple targets needs to be worked out.

oops, how about, "@peg revision indicates in which revision targets are
valid ..." ?

The patch does not attempt to change the current behaviour of 'svn log',
which does not allow multiple wc paths, or specify more than one url.
. Here is the section from clients/cmdline/log-cmd.c

/* Verify that we pass at most one working copy path. */
  if (! svn_path_is_url (target) )
      if (targets->nelts > 1)
        return svn_error_create (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
                                 _("When specifying working copy paths, only "
                                   "one target may be given"));
      /* Check to make sure there are no other URLs. */
      for (i = 1; i < targets->nelts; i++)
          target = APR_ARRAY_IDX (targets, i, const char *);

          if (svn_path_is_url (target))
            return svn_error_create (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
                                     _("Only relative paths can be specified "
                                       "after a URL"));



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 12 15:54:57 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.