Re: [PATCH]: Trying to get rid of iconv dependency on windows

Malcolm Rowe wrote:
> On Wed, Oct 12, 2005 at 07:18:51PM +0200, Stefan Küng wrote:
>
>>This patch introduces a new compile time define NOICONV which if set,
>>will do the UTF8 string conversions with the Windows API's instead of
>>using apr_iconv.
>>
>
>
> Be careful. I'm sure I remember finding out that the Windows functions
> are completely broken in some circumstances, although for the life of me
> I can't remember what those are, other than it had something to do with
> UTF-8. It may well be restricted to CJK, Thai, or Vietnamese codepages,
> and/or be to do with composite characters, in which case it might not
> be a problem.

Well, a google search with "multibytetowidechar broken utf8" brings up
only four entries in the group search. I think that's enough (at least
for me) to assume that it works.

And I don't think it's an argument to prevent this patch from going in,
if you can't even tell under *what* circumstances these functions are
broken.

If you can show us that those API's are really broken, then that would
be another matter, but like this? Also remember that e.g. TSVN uses
those API's exclusively to convert from/to UTF8 when passing/getting
params from the Subversion API.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org