Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'
On Thu, 2005-10-06 at 01:57, Philip Martin wrote:
> "Madan US" <email@example.com> writes:
> >>>> I think svn_path_canonicalize is the wrong place to be handling '@'
> >>>> for peg revisions. All peg handling should happen in opt.c.
> >>> We are not handling the peg revisions here. We are only adjusting the
> >>> input path so that a filename with @ and followed by a trailing / would
> >>> be
> >>> recognised by the code that handles peg revisions (opt.c?) ... in this
> >>> case, by replacing the trailing / with an @, so that
> >>> svn_opt_parse_path()
> >>> recognises the @ in the filename and not as an indicator for a peg
> >>> revision...
> >> It's possible that there are clients that don't use the '@nnn' syntax
> >> for peg revisions, it's a bit of a hack after all. Those clients will
> >> want to use svn_path_canonicalize so that function cannot treat '@' as
> >> special.
> > .... and those client will use libsvn_subr?
> They may well use svn_path_canonicalize.
you are right.
> > which takes the @ as a peg
> > revision marker?
> At present only svn_opt_parse_path in opt.c hadles '@' as a peg
> revision. Your patch spreads that special behaviour into a second
> function in a different file, that's bad.
Yes, its bad. Thanks for pointing out.
> I think it's a mistake for svn_path_canonicalize to treat '@' as
> special. I think it's a mistake to try to make a trailing '/' behave
> in the same way as a trailing '@'. If there are circumstances when a
> trailing '@' doesn't work then it would be better to fix them.
hmmm... I was thinking of taking this logic into svn_opt_parse_path()...
but as I mentioned in my reply to Lundblad, svn_opt_parse_path() would
never see the trailing '/' that the user entered...
Okay, I will update the issue and ask Eli/Karl for their comments...
To unsubscribe, e-mail: firstname.lastname@example.org
For additional commands, e-mail: email@example.com
Received on Thu Oct 6 09:51:02 2005
This is an archived mail posted to the Subversion Dev