[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-10-06 09:50:09 CEST

On Thu, 2005-10-06 at 01:40, Peter N. Lundblad wrote:
> On Wed, 5 Oct 2005, Madan US wrote:
[snip]
> > Since its svn_path_canonicalize() that causes the symptom in the first
> > place, I have tried to make it understand (a little intelligently) that
> > the user might have used the trailing / intentionally - if the last
> > segment of the filename contains an @ symbol (The trailing slash
> > wouldnt make sense if what comes after that @ is a revision number).
> > Hence the behavior of using a trailing / should be treated as if an
> > trailing @ was present.
> >
> I haven't looked at this in detail, but to me it sounds like the path is
> canonicalized *before* the peg revision is stripped. Couldn't you just
> reverse the order? (Just a suggestion)
Yes, and its called in the following sequence...
svn_cl__proplist()->svn_opt_args_to_target_array2()->svn_path_canonicalize()

peg revision processing happens here...
svn_cl__proplist()->svn_opt_parse_path()

where the former is (rightly) done before the latter. So, we cant
reverse the order.. :(

Pl. do let me know if theres something am missing...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 6 09:42:34 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.