Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'

"Madan US" <madan@collab.net> writes:

>> Madan U Sreenivasan <madan@collab.net> writes:
>>
>>> On Wed, 2005-10-05 at 02:56, Philip Martin wrote:
>>>> "Madan US" <madan@collab.net> writes:
>>>> >
>>>> > * subversion/libsvn_subr/path.c
>>>> > (svn_path_canonicalize): Modified to replace the trailing slash
>>>> > in the filename to @ if the last segment of the file path
>>>> > contained an @.
>>
>> I think svn_path_canonicalize is the wrong place to be handling '@'
>> for peg revisions. All peg handling should happen in opt.c.
>
> We are not handling the peg revisions here. We are only adjusting the
> input path so that a filename with @ and followed by a trailing / would be
> recognised by the code that handles peg revisions (opt.c?) ... in this
> case, by replacing the trailing / with an @, so that svn_opt_parse_path()
> recognises the @ in the filename and not as an indicator for a peg
> revision...

It's possible that there are clients that don't use the '@nnn' syntax
for peg revisions, it's a bit of a hack after all. Those clients will
want to use svn_path_canonicalize so that function cannot treat '@' as
special.

> Can you think of a better way to handle this in opt.c? If so, pl. let me
> know...

I don't understand the issue: I'd like a description of the behaviour
you are trying to implement.

Why can't we simply require the user to input a trailing '@' instead
of a trailing '/'? When did trailing '/' become special?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org