> Madan U Sreenivasan <madan@collab.net> writes:
>
>> On Wed, 2005-10-05 at 02:56, Philip Martin wrote:
>>> "Madan US" <madan@collab.net> writes:
>>> >
>>> > * subversion/libsvn_subr/path.c
>>> > (svn_path_canonicalize): Modified to replace the trailing slash
>>> > in the filename to @ if the last segment of the file path
>>> > contained an @.
>
> I think svn_path_canonicalize is the wrong place to be handling '@'
> for peg revisions. All peg handling should happen in opt.c.
We are not handling the peg revisions here. We are only adjusting the
input path so that a filename with @ and followed by a trailing / would be
recognised by the code that handles peg revisions (opt.c?) ... in this
case, by replacing the trailing / with an @, so that svn_opt_parse_path()
recognises the @ in the filename and not as an indicator for a peg
revision...
Can you think of a better way to handle this in opt.c? If so, pl. let me
know...
[snip]
>
>> I did notice the change to tests/libsvn_subr/opt-test.c made for
>> r15289. I couldnt figure out how it works.
>
> It's fairly simple, it's just an array of inputs to, and expected
> outputs from, svn_opt_parse_path.
Oh, that was my understanding too... would submit the patch again with
this done... thanks for the input...
Regards,
Madan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 5 21:11:01 2005