[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_wc/status.c:assemble_status() doc string lies?

From: <kfogel_at_collab.net>
Date: 2005-10-04 21:30:03 CEST

Daniel Rall <dlr@finemaltcoding.com> writes:
> --- status.c (revision 16464)
> +++ status.c (working copy)
> @@ -190,11 +190,10 @@
>
> ENTRY may be null, for non-versioned entities. In this case, we
> will assemble a special status structure item which implies a
> - non-versioned thing.
> + non-versioned thing. As non-null ENTRY will be deep copied (as
> + opposed to stored directly), and the lifetime its pool is not
> + important.
>
> - Else, ENTRY's pool must not be shorter-lived than STATUS's, since
> - ENTRY will be stored directly, not copied.
> -
> PARENT_ENTRY is the entry for the parent directory of PATH, it may be
> NULL if ENTRY is NULL or if PATH is a working copy root. The lifetime
> of PARENT_ENTRY's pool is not important.

A bit verbose, maybe just:

  + non-versioned thing. If non-null, ENTRY's lifetime is
  + unimportant, as it will be deep-copied into *STATUS.

?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 22:40:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.