[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Re: -F help text

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-04 17:39:34 CEST

Christian Stork wrote:
> On Sun, Sep 18, 2005 at 01:38:45PM +0100, Max Bowsher wrote:
>> Christian Stork wrote:
>> >'svn help ci' says
>> >...
>> > -m [--message] arg : specify commit message ARG
>> > -F [--file] arg : read data from file ARG
>> > ^^^^
>
>> >Why "data" and not the more specific "commit message"?
>
>> Because our CLI option handling framework is currently incapable of
>> showing
>> different help messages depending on the subcommand involved, and -F is
>> used for both "svn commit -F commit_message_file", and "svn propset -F
>> property_value_file".
>> Hence the vague "data".
>
>> Yes, this is a bit silly - but no one has yet got around to improving the
>> code.
>
> This is my first real patch so please be gentle. ;-)
>
> [[[
>
> Add subcommand-specific option descriptors in a new field in
> svn_cl__cmd_table entries and use them for more sensible help
> messages.
> To illustrate, entries for -m and -F are added.
...

Thank you *very* much for taking the time to work on this.

I just wanted to let you know that I've got this saved in my TODO folder for
attention as soon as the impending 1.3.0 release is out of the way.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 17:41:05 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.